Project

General

Profile

Bug #3987

NPCs attack after some taunting with no "Goodbye"

Added by Demid Doroginin 4 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Category:
Game Mechanics
Target version:
Start date:
08/03/2017
% Done:

100%

Reproducibility:
Sometimes
Operating system:
Other
Severity:
Normal

Description

Sometimes if NPC is successfully taunted 4-5 times it won't show "Goodbye" message and will talk to you, but when you exit the dialogue window, NPC will attack you.

Associated revisions

Revision d1489f5b (diff)
Added by Andrei Kortunov 4 months ago

Take in account a temporary disposition in isAggressive check (bug #3987)

History

#1 Updated by Andrei Kortunov 4 months ago

  • Status changed from New to Confirmed
  • Reproducibility changed from Random to Sometimes
  • Operating system changed from Windows to Other

Confirmed. I guess there is a bug in Should Attack check.

#2 Updated by scrawl . 4 months ago

From what I can tell, the change to disposition is only applied when you close the dialogue window, and the "should attack" check (or isAggressive as called in our code) does not account for that unapplied change. Changing the call getDerivedDisposition(ptr, false) to getDerivedDisposition(ptr, true) in MechanicsManager::isAggressive might fix this issue.

#3 Updated by Andrei Kortunov 4 months ago

Changing the call getDerivedDisposition(ptr, false) to getDerivedDisposition(ptr, true) in MechanicsManager::isAggressive might fix this issue.

It seems you are right.

#4 Updated by Andrei Kortunov 4 months ago

  • Status changed from Confirmed to Resolved

#5 Updated by Andrei Kortunov 4 months ago

  • % Done changed from 0 to 100

#6 Updated by Andrei Kortunov 4 months ago

  • Status changed from Resolved to Closed

#7 Updated by Alexei Dobrohotov 3 months ago

  • Assignee set to Andrei Kortunov

Also available in: Atom PDF