Project

General

Profile

Bug #3892

Empty space before dialogue entry display

Added by rot tor 4 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
GUI
Target version:
Start date:
06/01/2017
% Done:

0%

Reproducibility:
Always
Operating system:
Windows
Severity:
Minor

Description

In the dialogue window, whenever a topic is called both the topic (in bold) and the dialogue are displayed. In openMW there is an empty line or empty space between the topic name and the dialogue line itself.
There is also an empty space before greetings are displayed (only apparent if a mod uses ForceGreeting to display several entries in a row).

(in 0.41. May 04 nightly)

Associated revisions

Revision c2962ced (diff)
Added by Andrei Kortunov 4 months ago

Removed empty space before dialogue entry (bug #3892)

Revision 59eb0aba
Added by scrawl . 4 months ago

Merge pull request #1310 from akortunov/guifixes

Removed empty space before dialogue entry (bug #3892)

History

#1 Updated by Andrei Kortunov 4 months ago

A first case is ok, but I am not sure that we need to implement a second case (both greetings and responses in OpenMW use DialogueWindow::addResponse function).

We can remove empty line between response text and response caption by removing argument from sectionBreak() function at this line: https://github.com/OpenMW/openmw/blob/master/apps/openmw/mwgui/dialogue.cpp#L122

#2 Updated by rot tor 4 months ago

(to clarify, I meant that using ForceGreeting while already in dialogue will show a space before the new line in OpenMW, but no space in the original engine - that's a technique only used by mods)

#3 Updated by Andrei Kortunov 4 months ago

It seems Morrowind places a second empty line between entries only if a last entry has a caption (bold string).

#4 Updated by Alexei Dobrohotov 4 months ago

  • Category set to GUI
  • Status changed from New to Resolved
  • Target version set to openmw-0.43

#5 Updated by Alexei Dobrohotov 4 months ago

  • Status changed from Resolved to Closed

#6 Updated by Alexei Dobrohotov about 2 months ago

  • Assignee set to Andrei Kortunov

Also available in: Atom PDF