Project

General

Profile

Bug #3891

Journal displays empty entries

Added by rot tor 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
06/01/2017
% Done:

100%

Reproducibility:
Always
Operating system:
Windows
Severity:
Minor

Description

If an empty entry was created for a journal index value, the original engine did not display it ingame nor notify a journal update.

(in 0.41. May 04 nightly)

A1_Dreams.esp (515 Bytes) rot tor, 06/04/2017 07:56 PM

Associated revisions

Revision 7fcb22b8 (diff)
Added by Andrei Kortunov 5 months ago

Do not show empty journal entries (fixes #3891)

Revision ea5fe4b6
Added by scrawl . 5 months ago

Merge pull request #1328 from akortunov/journalfix

Do not show empty journal entries (fixes #3891)

History

#1 Updated by rot tor 6 months ago

(by the way the point of making an empty journal entry, instead of just using that number without creating an entry, is to make that journal title "Finish" or "Restart" without adding a new entry)

#2 Updated by Andrei Kortunov 6 months ago

How can we reproduce this bug?

#3 Updated by rot tor 6 months ago

I don't know if the base game ever uses empty entries, it's probably just mods,
In this file I've added an empty finishing entry to A1_Dreams, if you use

Journal A1_Dreams 100

in the openMW console you will get the date added in the journal.

#4 Updated by Andrei Kortunov 6 months ago

nor notify a journal update

Are you sure? I tested your plugin with original Morrowind. An empty entry indeed was not shown in journal, but I got a notify about journal was updated.

#5 Updated by rot tor 6 months ago

I'm sure it didn't notify while in dialogue, though journal entries with text and other messageboxes do display there. I guess it's different if you're not in dialogue then?

#6 Updated by Andrei Kortunov 6 months ago

I guess it's different if you're not in dialogue then?

Yes, it's different. Why, Bethesda :( ?

Anyway, I suggest to do not display notification in both dialogue and non-dialogue mode.
But we need a feedback from other developers first.

#7 Updated by Alexei Dobrohotov 5 months ago

  • Category set to General
  • Status changed from New to Resolved
  • Target version set to openmw-0.43
  • % Done changed from 0 to 100

#8 Updated by Andrei Kortunov 5 months ago

  • Status changed from Resolved to Closed

#9 Updated by Alexei Dobrohotov 4 months ago

  • Assignee set to Andrei Kortunov

Also available in: Atom PDF