Project

General

Profile

Bug #2641

OpenMW-CS: no check if file given as parameter is existing/accessible/valid file type

Added by Who Knows over 2 years ago. Updated about 1 month ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Editor
Target version:
Start date:
06/09/2015
% Done:

0%

Reproducibility:
Always
Operating system:
Linux
Severity:
Normal

Description

Files given as parameter to functions are not checked at compile time and not found by the OpenMW-CS "verify" functionality.
1) check for existence, this seems perfectly valid: Say "/dev/zero/purzelbaum" "haha"
2) no check if accessible, no complaining : Say "/root/no_way.wav" "come in"
3) check file type, no error thrown: Say "/home/share/screenshot.bmp" "peng"

History

#1 Updated by Marc Zinnschlag over 2 years ago

  • Category set to Scripting
  • Target version set to openmw-0.41

Please that we do not operate directly on absolute file locations (as suggested in the description). We operate on resources, which can be files in data directories and selected archives.

#2 Updated by Who Knows over 2 years ago

That was just to make a clear example of what would be good to check pre-execution. What I mean is that

Say "I_do_not_exist.wav"

should give a warning if that file is not in the right folder or not readable or if it holds picture data.
In the latter case checking the magic number might be enough.

#3 Updated by scrawl . over 2 years ago

Why is this on target version openmw-1.0? I thought the plan was to release 1.0 even if the editor isn't complete yet.

#4 Updated by Marc Zinnschlag over 2 years ago

I don't think we have made a final decision about that. If OpenMW-CS 1.0 is only slightly behind OpenMW 1.0 we might as well release them together. For the time being I consider the openmw-1.0 target to cover the whole project. If we decide that we want to release OpenMW 1.0 first, we can still move the OpenMW-CS issues to a new target.

#5 Updated by scrawl . over 2 years ago

Would you mind if I created a separate openmw-cs-1.0 milestone just to keep things organized?

#6 Updated by Marc Zinnschlag over 2 years ago

If you want. I don't mind.

#7 Updated by scrawl . over 2 years ago

  • Target version changed from openmw-0.41 to openmw-cs-1.0

#8 Updated by scrawl . about 1 month ago

  • Subject changed from OpenMW && OpenMW-CS: no check if file given as parameter is existing/accessible/valid file type to OpenMW-CS: no check if file given as parameter is existing/accessible/valid file type
  • Category changed from Scripting to Editor

Also available in: Atom PDF