Project

General

Profile

Task #172

Sound Manager Cleanup

Added by Marc Zinnschlag about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Category:
Code Maintenance
Target version:
Start date:
10/09/2011
% Done:

100%

Severity:
Minor

Description

Like most of the old classes the sound manager accumulated a lot of cruft:

- remove Pimpl implementation (of no use here)
- remove boost::timer and replace it with the frame duration passed into the update function
- Do not store a copy of the current region (can be retrieved from the ESMStore when needed; just store the name); also remove the "total" member variable.
- Do not pass the ESMStore to the constructor. It can be retrieved via the Environment instance
- Do not use internal component/esm types: ESM::NAME32. Just a plain std::string instead.

History

#1 Updated by Marc Zinnschlag almost 6 years ago

  • Assignee set to Brandon Dulaney
  • Target version changed from openmw-future to openmw-0.12

#2 Updated by Brandon Dulaney almost 6 years ago

  • File 001-SoundManger-boost-timer.patch added

After taking a look at how boost::timer was being used, I decided to replace it with an iterating integer. OpenMW starts up and shuts down faster without any changes in sound quality.

#3 Updated by Brandon Dulaney almost 6 years ago

  • File deleted (001-SoundManger-boost-timer.patch)

#4 Updated by Marc Zinnschlag almost 6 years ago

  • Target version changed from openmw-0.12 to openmw-0.13

#5 Updated by Marc Zinnschlag over 5 years ago

  • Assignee deleted (Brandon Dulaney)

#6 Updated by Marc Zinnschlag over 5 years ago

  • Assignee set to Michael Papageorgiou
  • Priority changed from Low to High

#7 Updated by Marc Zinnschlag over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF